Feature/put #36

drnickallgood · 2018-04-14T22:13:17Z

No description provided.

bama4 · 2018-04-14T22:16:03Z

PROJ1/put/put.go

+func Put(data *msg.Data, respond_to int64) {
+
+	// Node gets data 
+	ring_nodes[respond_to].Data = data


I think this would be the right code if you were already at the node that is supposed to store the data.
The data I believe is supposed to be forwarded through the ring until it reaches the correct node that is supposed to store the data.
With "put" you are supposed to create a function that maps the "key" to a node that is supposed to store that key,value pair. The next step is to find the node that is supposed to store the data...at least thats what I got when I asked the processor

bama4 · 2018-04-14T23:18:34Z

PROJ1/put/put.go

+	// Node gets data 
+	ring_nodes[respond_to].Data = data
+
+	// network[respond_to] <- "Put"


For the first part which is the mapping function that maps the string data key to a node id, there are several ways of doing it. Below is just an example of one way of doing it but there could be better ways:
You could just add up all of the ascii values of the data keys' characters and then mod that by the number of nodes that we set in the program
`
num_of_nodes
.
.
data_mapping_function(key):
//get the sum of all of the characters in the key

char_sum = sum_of_all_chars(key)

node_id = char_sum % num_of_nodes

return node_id
`

The second part is finding the node that can store the data by passing it along the ring

bama4 · 2018-04-15T01:19:03Z

PROJ1/put/put.go

+	var node_id = map_to_string_id(data.Key, respond_to)
+
+	// Node gets data 
+	ring_nodes[node_id].Value = data.Value


remember you need to know where in the ring data that maps to node_id should go. This is done through routing NOT through using the ring_nodes map (the node id may not even be existing in the ring)
Also the data is stored in the DataTable entry in the node struct definition if you look in the node_defs package

The DataTable entry is fixed, but I can't seem to really understand the first part of the comment.. i know ring_nodes[node_id] probably isn't sufficient.. right?

ring_nodes[node_id] is a shortcut in my opinion. As i mentioned before, you need to find the correct spot to put the data through routing, not by using ring nodes for this particular instruction. If we could simply store the data using just the ring_nodes map, then that would defeat the purpose of using chord to store data in a distributed way

bama4 · 2018-04-15T01:20:01Z

PROJ1/put/put.go

+func Put(data *msg.Data, respond_to int64) {
+
+	// Get the node ID for data string
+	var node_id = map_to_string_id(data.Key, respond_to)


The map_to_string_id function just takes in a string, nothing else

bama4 · 2018-04-15T01:22:28Z

PROJ1/put/put.go

+	// map key from data.key to noe ID that is supposed to store
+	// Find specific node in ring , if doesn't exist, map to successor
+
+	// network[respond_to] <- "Put"


I feel like due to the way that we implemented our program, respond-to seems like an extra field so I am still not sure how to incorporate it in

bama4 · 2018-04-15T01:40:35Z

PROJ1/put/put.go

+	ring_nodes[node_id].Value = data.Value
+
+	// map key from data.key to noe ID that is supposed to store
+	// Find specific node in ring , if doesn't exist, map to successor


I think the node that first received the put message should check to see if the node id is in its routing fingertable table...if it is not in the table, then you should forward the data to the node in the table that is the closest to where the node_id would be.
If the node_id is bigger than the node that recieved the data, then maybe pass the data to the nodes predecessor and have the predecessor look up where to find node id.

bama4 · 2018-04-15T15:31:38Z

PROJ1/put/put.go

+
+	// Get the node ID for data string
+	var node_id = map_to_string_id(data.Key)
+


You may also want to look at the current node first to see if you are already at the node that should store the data

bama4 · 2018-04-15T22:58:18Z

PROJ1/put/put.go

+// Node gets this message
+// Use all the nodes fields
+
+func find_biggest_node(finger_table *map[int64]*Node, node_id int64)(biggest int64) {


I believe you can use the ClosestPrecedingNode function that is already in master that will find the closest node that comes before a given node id

bama4 · 2018-04-15T23:44:20Z

PROJ1/put/put.go

+			// It's not in our finger table
+			// Go to the biggest node without overshooting
+			// ClosestPrecedingNode function in master
+			var biggest = find_biggest_node(&FingerTable, node_id)		


Any reason for having both find biggest node and ClosestPRecedingNode?

bama4 · 2018-04-15T23:59:40Z

PROJ1/put/put.go

+	var node_id = map_to_string_id(data.Key)
+
+	// Check to see if this is the right node to store data
+	if ChannelId == node_id {


The channel id may not necessarily equal the node id

This was my attempt at looking at the current node to see if it's the correct one or not.. but i guess if i remember right.. the first entry in the node's fingertable is always itself i think?

bama4 · 2018-04-16T22:34:32Z

PROJ1/put/put.go

+		DataTable[data.Key] := data.Value
+		return 
+	} else {
+		for k, v := range FingerTable {


I think youd want either the closest preceeding node or youd want to start from the end of the table and work your way down...remeber, the ith index of node n's table represents where ids = i + 2^i should be routed to.

bama4 · 2018-04-17T02:39:57Z

PROJ1/put/put.go

+		DataTable[data.Key] := data.Value
+	} else {
+		// FindPReceedingNode
+		var closest_node = FindClosestPreceedingNode(&node_obj.FingerTable, data.Key)


This function sends the closest proceeding node to a bucket..
You meed to do GetDataFromBucket to retrieve the message...and then ExtractIdFromBucketData to get the value there are examples in the main code

…nto project1-master

…ctions correctly and getting it, but for whatever reason it still isn't showing up in the logs as being recieved

…nstructions nad utilizing check_error(err). Right now doesn't seem to find the closest node correct

… it doesn't do anything. For some reason even when it works I'm not seeing any of the log messages on the console

… found. Also a check to avoid looping if the current node is it's own successor

drnickallgood · 2018-05-03T12:28:59Z

Need to fix some things based on conversations:

Modify closet > key_id to use between func
format actual message to send to Successor instead of raw values (use JSON)

bama4 reviewed Apr 14, 2018

View reviewed changes

bama4 reviewed Apr 15, 2018

View reviewed changes

bama4 reviewed Apr 16, 2018

View reviewed changes

bama4 reviewed Apr 17, 2018

View reviewed changes

nallg00d and others added 18 commits April 16, 2018 23:11

Merge branch 'project1-master' of https://github.com/bama4/Projects i…

f1603c3

…nto project1-master

Added put

4b10bd9

Trying to figure out put

ba94f3f

quick update

d23f3b1

Merge branch 'project1-master' of https://github.com/bama4/Projects i…

caddf50

…nto project1-master

Trying to merge

72f25b8

Toying around with PutData

67e9eb4

Merge branch 'project1-master' of https://github.com/bama4/Projects i…

675a92d

…nto project1-master

merging latest master in

33bf149

Moved Data struct to be inside Message struct for correct JSON parsing

1f9c596

Merge branch 'project1-master' of https://github.com/bama4/Projects i…

722a96d

…nto project1-master

Still toying with put.. confirned net_nodes is parsing the put instru…

31ae859

…ctions correctly and getting it, but for whatever reason it still isn't showing up in the logs as being recieved

Fixed message parsing issue by removing respond-to from my own test i…

4868242

…nstructions nad utilizing check_error(err). Right now doesn't seem to find the closest node correct

added a bit more code to Put for node storage and some notes

0dee2b5

PutData sometimes works and updates a node's data table but sometimes…

8630bc2

… it doesn't do anything. For some reason even when it works I'm not seeing any of the log messages on the console

added conditions to send to successor in the event closest node isn't…

868ddde

… found. Also a check to avoid looping if the current node is it's own successor

Fixed typo in ChannelId

ed021da

Fixed Put, seems to work

a5ff7e4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/put #36

Feature/put #36

drnickallgood commented Apr 14, 2018

bama4 Apr 14, 2018 •

edited

Loading

bama4 Apr 14, 2018 •

edited

Loading

bama4 Apr 15, 2018 •

edited

Loading

drnickallgood Apr 15, 2018

bama4 Apr 15, 2018

bama4 Apr 15, 2018

bama4 Apr 15, 2018

bama4 Apr 15, 2018

bama4 Apr 15, 2018

drnickallgood Apr 16, 2018

bama4 Apr 15, 2018

drnickallgood Apr 16, 2018

bama4 Apr 15, 2018

bama4 Apr 15, 2018

drnickallgood Apr 16, 2018

bama4 Apr 16, 2018

bama4 Apr 17, 2018

drnickallgood commented May 3, 2018


		// Get the node ID for data string
		var node_id = map_to_string_id(data.Key)

Feature/put #36

Are you sure you want to change the base?

Feature/put #36

Conversation

drnickallgood commented Apr 14, 2018

bama4 Apr 14, 2018 • edited Loading

Choose a reason for hiding this comment

bama4 Apr 14, 2018 • edited Loading

Choose a reason for hiding this comment

bama4 Apr 15, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

drnickallgood commented May 3, 2018

bama4 Apr 14, 2018 •

edited

Loading

bama4 Apr 14, 2018 •

edited

Loading

bama4 Apr 15, 2018 •

edited

Loading