Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): Add llvm, clang and linker #83

Merged
merged 1 commit into from
Aug 22, 2024
Merged

feat(docker): Add llvm, clang and linker #83

merged 1 commit into from
Aug 22, 2024

Conversation

DavidMCerdeira
Copy link
Member

This PR adds as LLVM to the Bao docker in preparation for clang support in Bao.

Copy link
Member

@josecm josecm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep inline with the commit history, the message should be feat(docker): ...

@DavidMCerdeira
Copy link
Member Author

DavidMCerdeira commented Jul 26, 2024

@josecm I've updated the commit title

What are your thoughts on having the variable ARG CLANG_VERSION=18 only be applied to clang-format while we are installing the clang as well?

@DavidMCerdeira DavidMCerdeira changed the title feat(clang): Add llvm, clang and linker feat(docker): Add llvm, clang and linker Jul 30, 2024
@josecm
Copy link
Member

josecm commented Aug 21, 2024

@DavidMCerdeira add a fixed version of clang itself too

AfonsoSantos96
AfonsoSantos96 previously approved these changes Aug 21, 2024
Signed-off-by: David Cerdeira <[email protected]>
Signed-off-by: Jose Martins <[email protected]>
@danielRep danielRep merged commit e596c06 into main Aug 22, 2024
4 checks passed
@danielRep danielRep deleted the feat/clang branch August 22, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants