Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(doc): include bao test framework introduction #71

Open
wants to merge 2 commits into
base: wip/testing
Choose a base branch
from

Conversation

Diogo21Costa
Copy link
Member

PR Description

In this pull request, I'm adding content to the "Overview" section of the Bao test framework documentation.

This update focuses solely on the "Overview" section, providing an overview of the core components of the Bao test framework.

Do you have any suggestions or feedback concerning the content provided in the overview section?

danielRep
danielRep previously approved these changes Oct 23, 2023
Copy link
Member

@danielRep danielRep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add @Diogo21Costa , seems good to me as a small introduction to the document, since the next section I assume you will explain the "architecture" of the framework.

@josecm
Copy link
Member

josecm commented Oct 26, 2023

Does this PR supersedes #65 ?

source/development/testing.rst Outdated Show resolved Hide resolved
source/development/testing.rst Outdated Show resolved Hide resolved
source/development/testing.rst Outdated Show resolved Hide resolved
@Diogo21Costa
Copy link
Member Author

Does this PR supersedes #65 ?

Yes, it does @josecm.

source/development/testing.rst Outdated Show resolved Hide resolved
source/development/testing.rst Outdated Show resolved Hide resolved
danielRep
danielRep previously approved these changes Nov 20, 2023
Copy link
Member

@josecm josecm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be completely honest, the C library and Nix build system descriptions are a bit confusing. From these descriptions I would not get what they are meant to do.

@Diogo21Costa
Copy link
Member Author

To be completely honest, the C library and Nix build system descriptions are a bit confusing. From these descriptions I would not get what they are meant to do.

@josecm I agree. The commit 8543e50 includes some improvements. What do you think of this version?

Copy link
Member

@danielRep danielRep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase it with main and solve the checker issues.

source/development/testing.rst Outdated Show resolved Hide resolved
source/development/testing.rst Outdated Show resolved Hide resolved
source/development/testing.rst Outdated Show resolved Hide resolved
danielRep
danielRep previously approved these changes Dec 18, 2023
@josecm
Copy link
Member

josecm commented Feb 1, 2024

To be completely honest, the C library and Nix build system descriptions are a bit confusing. From these descriptions I would not get what they are meant to do.

@josecm I agree. The commit 8543e50 includes some improvements. What do you think of this version?

@Diogo21Costa TBH, I still think these descriptions are confusing, especially the C library one. Using simpler language, with fewer adjectives and more straight-to-the-point ideas, would be best.

Comment on lines 8 to 10
1. **C Library** - This library that streamlines testing by providing macros, pre-processed logging
prompts, and an entry-point-based system, aiming to facilitating the integration of developer
tests in the software stack, such as the hypervisor or guest components.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. **C Library** - This library that streamlines testing by providing macros, pre-processed logging
prompts, and an entry-point-based system, aiming to facilitating the integration of developer
tests in the software stack, such as the hypervisor or guest components.
1. **C Library** - This library provides a framework for writing tests. It defines (i) a runtime that automates the invocation of function unit tests and (ii) an API that mainly provides a way of outputing test results in a standard format that can be parsed by the Python Tool (see below).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed!

Comment on lines 12 to 16
2. **Nix Build System** - The Nix Build System introduces an abstraction layer for system builds,
facilitating a modular construction of the software stack for comprehensive testing. It
encompasses a series of nix recipes that allow the compilation and build of three distinct
layers: (i) the hypervisor, (ii) multiple guests (e.g., baremetal, freeRTOS, etc.), and (iii)
the firmware.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. **Nix Build System** - The Nix Build System introduces an abstraction layer for system builds,
facilitating a modular construction of the software stack for comprehensive testing. It
encompasses a series of nix recipes that allow the compilation and build of three distinct
layers: (i) the hypervisor, (ii) multiple guests (e.g., baremetal, freeRTOS, etc.), and (iii)
the firmware.
2. **Nix Build System** - The Nix Build System introduces an abstraction layer for system builds,
facilitating a modular construction of the target software stack used for testing. It
encompasses a series of nix recipes that allow the compilation and build of three distinct
layers: (i) the hypervisor, (ii) multiple guests (e.g., baremetal, freeRTOS, etc.), and (iii)
the firmware.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants