blocking_connection: Fix consume() return type #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3. Signed-off-by: Anders Kaseorg <[email protected]>
baodrate
pushed a commit
that referenced
this pull request
Jan 16, 2022
Mypy supports new Python features in stubs even when running on older Python versions. And at runtime, by definition, type stubs are not used or even imported at all. So there is no reason to restrict the Python version. Fixes #1. Signed-off-by: Anders Kaseorg <[email protected]>
baodrate
pushed a commit
that referenced
this pull request
Jan 16, 2022
Mypy supports new Python features in stubs even when running on older Python versions. And at runtime, by definition, type stubs are not used or even imported at all. So there is no reason to restrict the Python version. Fixes #1. Signed-off-by: Anders Kaseorg <[email protected]>
The return is either a tuple with all fields or a tuple with all None.
Remove the semantic ambiguity that allows for e.g.
-> Tuple[None, spec.BasicProperties, None]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes hahow/pika-stubs/issues/3.
Signed-off-by: Anders Kaseorg [email protected]
From hahow/pika-stubs/pull/4