Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Configurable require Configuration #2146

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Make Configurable require Configuration #2146

merged 1 commit into from
Oct 21, 2024
+501 −412

Conversation

bartfeenstra
Copy link
Owner

@bartfeenstra bartfeenstra commented Oct 19, 2024 •
edited
Loading

No description provided.

@bartfeenstra bartfeenstra added enhancement New feature or request BC break Breaks backwards compatibility with existing integrations python Pull requests that update Python code labels Oct 19, 2024
@bartfeenstra bartfeenstra added this to the 0.4.0 milestone Oct 19, 2024
@bartfeenstra bartfeenstra mentioned this pull request Oct 19, 2024
Open
@bartfeenstra bartfeenstra force-pushed the configurable-require-configuration branch from e5158e5 to 26c833a Compare October 19, 2024 11:32
@bartfeenstra bartfeenstra force-pushed the configurable-require-configuration branch from 38b8f99 to f8ac306 Compare October 19, 2024 12:46
@bartfeenstra bartfeenstra marked this pull request as ready for review October 19, 2024 12:50
@bartfeenstra bartfeenstra force-pushed the configurable-require-configuration branch 3 times, most recently from 8536438 to d8e9cb3 Compare October 19, 2024 23:09
bartfeenstra
bartfeenstra commented Oct 19, 2024
View reviewed changes
betty/plugin/config.py Outdated Show resolved Hide resolved
@bartfeenstra bartfeenstra force-pushed the configurable-require-configuration branch 4 times, most recently from 61a18e1 to 0da86e8 Compare October 20, 2024 23:54
@bartfeenstra bartfeenstra force-pushed the configurable-require-configuration branch from 0da86e8 to d781f78 Compare October 21, 2024 00:04
@bartfeenstra bartfeenstra merged commit 1e7e5aa into 0.4.x Oct 21, 2024
6 checks passed
@bartfeenstra bartfeenstra deleted the configurable-require-configuration branch October 21, 2024 00:14
@codecov Codecov
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 99.34641% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.29%. Comparing base (f649457) to head (d781f78).
Report is 1 commits behind head on 0.4.x.

Files with missing lines Patch % Lines
betty/project/__init__.py 75.00% 0 Missing and 1 partial ⚠️
betty/project/extension/webpack/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##            0.4.x    #2146   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files         358      358           
  Lines       22749    22781   +32     
  Branches     1058     1059    +1     
=======================================
+ Hits        22361    22393   +32     
+ Misses        246      245    -1     
- Partials      142      143    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BC break Breaks backwards compatibility with existing integrations enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
1 participant
@bartfeenstra