Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: different profiles per specific stream #8

Merged
merged 7 commits into from
Sep 4, 2024

Conversation

DanielHe4rt
Copy link
Contributor

Motivation

After the latest changes of tbp-extension, now you can have different profiles per each stream you visit.

By default, you will be always sending an /settings/{username}?channel_id=any-twitch-channel together with the username, if the user has an dedicated profile for that stream, it will be prioritized, if not will fallback to the global profile.

Didn't wrote any test here tbh but it would be good to have in the future.

Copy link
Contributor

@Daniel-Boll Daniel-Boll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking hella good

src/http/v1/settings_controller.rs Outdated Show resolved Hide resolved
Co-authored-by: Daniel Boll <[email protected]>
@DanielHe4rt DanielHe4rt merged commit 5868abe into develop Sep 4, 2024
1 check passed
@DanielHe4rt DanielHe4rt deleted the feat/multi-profile branch September 4, 2024 17:49
@DanielHe4rt DanielHe4rt restored the feat/multi-profile branch September 4, 2024 17:51
@gvieira18 gvieira18 deleted the feat/multi-profile branch September 28, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants