Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Member to Membership #108

Open
kaichaosun opened this issue Aug 29, 2020 · 1 comment
Open

Rename Member to Membership #108

kaichaosun opened this issue Aug 29, 2020 · 1 comment
Labels
project:core type:chore Effectively busy-work stuff
Milestone
Roadmap

Comments

@kaichaosun
Copy link

When reading the code, AgentID could be MemberID and UserID, this is confused to me, digging more, Member is more like Membership which maintains the relationship between a user and a company.

I'd like proposing to change from Member to Membership and related concepts.
@orthecreedence
Copy link
Member

Yes, I agree with you. Membership makes a bit more sense than Member.

@orthecreedence orthecreedence changed the title Make it clear between User and Member Rename Member to Membership Sep 1, 2020
@orthecreedence orthecreedence added project:core type:chore Effectively busy-work stuff labels Sep 1, 2020
@orthecreedence orthecreedence modified the milestones: v0.3 - Core, Roadmap Sep 1, 2020
@orthecreedence orthecreedence mentioned this issue Sep 4, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
project:core type:chore Effectively busy-work stuff
Projects
None yet
Milestone
Roadmap
Development

No branches or pull requests
2 participants
@orthecreedence @kaichaosun