Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getting started #6

Merged
merged 12 commits into from
Jul 6, 2020
Merged

Add getting started #6

merged 12 commits into from
Jul 6, 2020

Conversation

oScape
Copy link
Member

@oScape oScape commented Jul 1, 2020

See #2.

@oScape oScape self-assigned this Jul 1, 2020
@oScape oScape added the documentation Improvements or additions to documentation label Jul 1, 2020
Copy link
Contributor

@o0Ignition0o o0Ignition0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, a couple of nits and we can get this merged!

src/ch01-00-getting-started.md Outdated Show resolved Hide resolved
src/ch01-00-getting-started.md Outdated Show resolved Hide resolved
src/ch01-00-getting-started.md Outdated Show resolved Hide resolved
src/ch01-00-getting-started.md Show resolved Hide resolved
The most classic of all examples and especially the essential hello, world! Only for you, in Bastion.
```rs
fn main() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably the same nits as bastion-rs/bastion#234 ^^

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will change this one, when we will merge the PR on bastion-rs.

@oScape oScape requested a review from o0Ignition0o July 6, 2020 07:22
Copy link
Contributor

@o0Ignition0o o0Ignition0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@oScape oScape merged commit 16705b8 into master Jul 6, 2020
@oScape oScape deleted the add-getting-started branch July 6, 2020 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants