remote_execution: add digest metadata #303
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional routing metadata for REAPI RPCs. These are plain-text HTTP headers that can be parsed by popular load balancers or reverse proxy solutions such as Caddy and Nginx to route RPC requests to appropriate server instances. RPC requests referencing or containing a single blob can use the `blob-digest` header to provide routing hint information. RPC requests referencing or containing multiple blobs can use one blob, or none, as a routing hint via the `blob-digest` header.
EdSchouten
reviewed
Jul 9, 2024
| // serialization: | ||
| // | ||
| // * name: `build.bazel.remote.execution.v2.blob-digest` | ||
| // * contents: the plained text digest of the blob in the form of "{hash}/{size}". |
There was a problem hiding this comment.
Instead of reinventing our own format for this string, any chance we can just reuse the existing bytestream path string? So prefixed with the instance name, potentially containing the digest function, etc.
There was a problem hiding this comment.
In that case probably best to call this build.bazel.remote.execution.v2.resource-name?
| // | ||
| // * name: `build.bazel.remote.execution.v2.blob-digest` | ||
| // * contents: the plained text digest of the blob in the form of "{hash}/{size}". | ||
| message BlobDigest {} |
There was a problem hiding this comment.
Is this message type actually needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional routing metadata for REAPI RPCs.
These are plain-text HTTP headers that can be parsed by popular load balancers
or reverse proxy solutions such as Caddy and Nginx to route RPC requests to
appropriate server instances.
RPC requests referencing or containing a single blob can use the
blob-digestheader to provide routing hint information.
RPC requests referencing or containing multiple blobs can use one blob, or
none, as a routing hint via the
blob-digestheader.