Remove failure when bindgen cc_lib does not contain static library #2742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @jwnrt, the PR makes sense. Would you mind adding a separate example in examples/bindgen (for example a header that is used from both Rust and C++, and both libraries meet in a common binary) showing everything links together well? |
|
Sure, I've added an example, let me know if it matches what you expected |
jwnrt
force-pushed
the
bindgen-header-only
branch
2 times, most recently
from
061bbff
to
57499cf
Compare
jwnrt
force-pushed
the
bindgen-header-only
branch
2 times, most recently
from
4759a02
to
5b4111d
Compare
jwnrt
force-pushed
the
bindgen-header-only
branch
from
02f063c
to
3903aa1
Compare
|
Fixed those formatting problems (hopefully you folks don't mind me rebasing to keep the branch up to date) |
jwnrt
force-pushed
the
bindgen-header-only
branch
from
3903aa1
to
9fc138f
Compare
|
Friendly bump: this is ready for review again. We can apply this as a patch downstream, so no rush from me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this failure is required: it's fine to bindgen a library with only headers and no static library. Should this error instead be triggering when the
cc_libraryhas non-header files but isn't static?Fixes #2704