Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept rust_library_group in proc_macro_deps #2900

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ashi009
Copy link

@ashi009 ashi009 commented Sep 24, 2024

Fixes #2892

@@ -647,7 +648,7 @@ _common_attrs = {
List of `rust_proc_macro` targets used to help build this library target.
"""),
cfg = "exec",
providers = [rust_common.crate_info],
providers = [[rust_common.crate_group_info], [rust_common.crate_info]],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This accepts crate_group_info providers, but then doesn't look for them? I think you'd need a second branch in the if you added which looks for crate_group_info and if it's present, iterates across them to look in their crate_info values?

Please could you add a test which uses this functionality, so we can see the code definitely works?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This accepts crate_group_info providers, but then doesn't look for them? I think you'd need a second branch in the if you added which looks for crate_group_info and if it's present, iterates across them to look in their crate_info values?

This follows the established checking logic for deps, on top of this change. So I didn't add a second branch. Also, as crate_group_info returns a depset, do we want to flatten that just for checking?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proc_macro_deps should accept rust_library_group
2 participants