Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAJOR! Refactor bsp to class #278

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

MAJOR! Refactor bsp to class #278

wants to merge 9 commits into from

Conversation

eirikbjornr
Copy link
Contributor

📺 What

Refactor BigscreenPlayer to a Javascript Class.

🛠 How

Changed BigscreenPlayer from function to Class, updating tests accordingly.

💡 Why

A step closer to implementing f.ex. the EventTarget API. This removes the need for registered callbacks and plugins in their current usage. This feature (+ @deprecated-ing all registerCb and plugins) would be a good next step.

✅ Testing

TBD

✅ Acceptance criteria

TBD

@eirikbjornr eirikbjornr added the semver major This PR is a semver major release label Dec 1, 2022
@eirikbjornr eirikbjornr self-assigned this Dec 1, 2022
ShiningTrapez
ShiningTrapez reviewed Dec 1, 2022
View reviewed changes
Copy link
Contributor

@ShiningTrapez ShiningTrapez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Like the use of extremely modern JS like class fields

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShiningTrapez ShiningTrapez ShiningTrapez left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@eirikbjornr eirikbjornr

Labels
semver major This PR is a semver major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eirikbjornr @ShiningTrapez