Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding exponential backoff #26

Merged
merged 4 commits into from
Sep 29, 2024
Merged

Conversation

nicholasgriffintn
Copy link
Member

Adds exponential backoff to the cloudflare library, enabling it to better handle 429 errors.

Copy link

codeclimate bot commented Sep 29, 2024

Code Climate has analyzed commit a879004 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 56.6% (80% is the threshold).

This pull request will bring the total coverage in the repository to 75.0% (-0.5% change).

View more on Code Climate.

@@ -17,13 +18,41 @@ export function getCredentials() {
};
}

async function exponentialBackoff<T>(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function exponentialBackoff has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

);
}

async function exponentialBackoff<T>(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function exponentialBackoff has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

@nicholasgriffintn nicholasgriffintn merged commit 5dd275f into main Sep 29, 2024
5 of 6 checks passed
@nicholasgriffintn nicholasgriffintn deleted the exponental-backoff branch September 29, 2024 15:14
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant