chore: upgrade nodejs to maintenance and lts (18 and 20) #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think through recent maintenance days we've been attempting to push everything up to Node 20. i.e. https://github.com/bbc/rd-ux-storyplayer-harness/commit/7e92efb86da5e28fdd3a5e0447655f4f48e135a1 I'd upgrade the dockerFile too: storyplayer/docker-compose.yml Line 5 in c59e957 Maybe also the node types package if we're building on Node 20: Line 43 in c59e957 |
yakca
changed the title
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Node 16 is EOL, this bumps the build image and github action workflows to 18 and 20.
Ticket / issue URL
Ticket / issue URL:
https://jira.dev.bbc.co.uk/browse/PRODTOOLS-4144
https://jira.dev.bbc.co.uk/browse/PRODTOOLS-4020
PR Checks
(tick as appropriate)