Merge pull request #532 from bcgov/ccof-puppeteer-debug

Fix race condition and update docker image to current LTS
bcgov · Oct 10, 2024 · 091ba91 · 091ba91
2 parents dc44cfb + 12265fe
commit 091ba91
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/backend/Dockerfile b/backend/Dockerfile
@@ -1,4 +1,4 @@
-FROM artifacts.developer.gov.bc.ca/docker-remote/node:16.20.0-alpine3.18
+FROM artifacts.developer.gov.bc.ca/docker-remote/node:20.18.0-alpine3.20
 
 ENV NPM_CONFIG_CACHE /tmp/npm
 RUN mkdir -p /logs \

diff --git a/backend/src/components/application.js b/backend/src/components/application.js
@@ -504,11 +504,13 @@ async function printPdf(req, numOfRetries = 0) {
 
       await postChangeRequestSummaryDocument(payload);
     }
-
+    browser.close();
     return payload;
   } catch (e) {
     log.error(e);
 
+    if (browser.process() !== null) { await browser.close(); }
+
     if (numOfRetries >= 3) {
       log.info('printPdf :: maximum number of retries reached');
       log.error(`printPdf :: unable to save pdf for application id ${req.params.applicationId}`);
@@ -519,8 +521,6 @@ async function printPdf(req, numOfRetries = 0) {
       log.info(`printPdf :: retry count ${retryCount}`);
       await printPdf(req, retryCount);
     }
-  } finally {
-    await browser.close();
   }
 }