Merge pull request #1962 from bcgov/feature/ALCS-2134-2

QA Fix: Fix NOI Tags Not Being Saved Correctly Upon Submission
bcgov · Nov 6, 2024 · 01791a8 · 01791a8
2 parents 6930ffd + fd0cdfe
commit 01791a8
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/services/apps/alcs/src/alcs/notice-of-intent/notice-of-intent.service.ts b/services/apps/alcs/src/alcs/notice-of-intent/notice-of-intent.service.ts
@@ -426,15 +426,15 @@ export class NoticeOfIntentService {
     await this.repository.save(existingNoticeOfIntent);
 
     if (createDto.tags && createDto.tags.length > 0) {
-      createDto.tags.map(async (tag) => {
+      for (const tag of createDto.tags) {
         try {
           await this.noticeOfIntentTagService.addTagToNoticeOfIntent(createDto.fileNumber, tag);
         } catch (e) {
           this.logger.error(
             `Could not add tag ${tag} to application number ${createDto.fileNumber} with error: ${e.error}`,
           );
         }
-      });
+      }
     }
 
     return this.getByFileNumber(createDto.fileNumber);