Code Review Feedback

bcgov · Mar 7, 2024 · 8ad053e · 8ad053e
1 parent 914e923
commit 8ad053e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 11 deletions.
diff --git a/alcs-frontend/src/app/features/planning-review/header/header.component.spec.ts b/alcs-frontend/src/app/features/planning-review/header/header.component.spec.ts
@@ -3,7 +3,7 @@ import { RouterTestingModule } from '@angular/router/testing';
 
 import { HeaderComponent } from './header.component';
 
-describe('DetailsHeaderComponent', () => {
+describe('HeaderComponent', () => {
   let component: HeaderComponent;
   let fixture: ComponentFixture<HeaderComponent>;
 

diff --git a/alcs-frontend/src/app/features/planning-review/overview/overview.component.ts b/alcs-frontend/src/app/features/planning-review/overview/overview.component.ts
@@ -1,7 +1,7 @@
 import { Component, OnDestroy, OnInit } from '@angular/core';
 import { Subject, takeUntil } from 'rxjs';
 import { PlanningReviewDetailService } from '../../../services/planning-review/planning-review-detail.service';
-import { PlanningReviewDto, PlanningReviewTypeDto } from '../../../services/planning-review/planning-review.dto';
+import { PlanningReviewDto } from '../../../services/planning-review/planning-review.dto';
 import { PlanningReviewService } from '../../../services/planning-review/planning-review.service';
 
 @Component({

diff --git a/services/apps/alcs/src/alcs/staff-journal/staff-journal.dto.ts b/services/apps/alcs/src/alcs/staff-journal/staff-journal.dto.ts
@@ -36,10 +36,6 @@ export class CreateNoticeOfIntentStaffJournalDto extends BaseCreateStaffJournalD
   @IsString()
   @IsNotEmpty()
   noticeOfIntentUuid: string;
-
-  @IsString()
-  @IsNotEmpty()
-  body: string;
 }
 
 export class CreateNotificationStaffJournalDto extends BaseCreateStaffJournalDto {
@@ -54,12 +50,8 @@ export class CreatePlanningReviewStaffJournalDto extends BaseCreateStaffJournalD
   planningReviewUuid: string;
 }
 
-export class UpdateStaffJournalDto {
+export class UpdateStaffJournalDto extends BaseCreateStaffJournalDto {
   @IsString()
   @IsNotEmpty()
   uuid: string;
-
-  @IsString()
-  @IsNotEmpty()
-  body: string;
 }