Feature/gw redirect #1178
Merged
Feature/gw redirect #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really glad I was forced to circle back on this. Much cleaner redirect implementation now using AuthProvider (which already had some logic to look if a page requires a namespace) alongside links.ts and doing away with NoGatewayRedirect. Less code, less weird pauses and jumpy redirects.
Keeps the toast on redirect.
Also used the updates to links.ts to add redirect from Your Products to My Gateways if no gateway selected. And cleaned up the conditional for showing the NamespaceMenu (dropdown selector).
🚀 Feature branch deployment: https://api-services-portal-feature-gw-redirect.apps.silver.devops.gov.bc.ca