Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clickable items in Gateways list #1179

Merged
merged 2 commits into from
Sep 19, 2024
Merged

clickable items in Gateways list #1179

merged 2 commits into from
Sep 19, 2024

Conversation

rustyjux
Copy link
Contributor

@rustyjux rustyjux commented Sep 13, 2024

I believe this is the first instance in which we have a clickable item / card sort of situation. This is a little one-off addition using Chakra inline styles but if we wanted to implement this sort of thing more widely, we could come up with a reusable component.

Or we could continue to use inline styles and handle each component individually.


🚀 Feature branch deployment: https://api-services-portal-feature-click-gateway-item.apps.silver.devops.gov.bc.ca

Copy link

@timng-bcgov timng-bcgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two observations on the styling of the list items.

  1. I'm wondering if we're able to style the Gateway display name with an underline based on the state of the parent to better match the styling of cards in the Gateways manager:

Current:
image

Comparison (expected from Gateway details):
image

Quick mockup to illustrate:
image

  1. Should we think about focus states for the list items? They seem to be absent on a few links throughout the Services portal. Is it possible to use a Chakra Link component (which composes <Box /> and has the desired focus state) instead of a <Flex /> with an onClick event? Might be worth discussing the composition here if we are planning on making a reusable component.

@Elson9 Elson9 merged commit 9ba051e into dev Sep 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable clickable gateway list item panel for improved navigation
3 participants