Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tests to handle redirect away from your products #1185

Merged
merged 3 commits into from
Nov 6, 2024
Merged

fix tests to handle redirect away from your products #1185

merged 3 commits into from
Nov 6, 2024

Conversation

rustyjux
Copy link
Contributor

@rustyjux
Copy link
Contributor Author

I'm not entirely sure why https://github.com/bcgov/api-services-portal/actions/runs/11373768072/job/31641057917 failed but I added the upload of the Astra scan result so if things do pop up there in future we can at least see the scan result.

@rustyjux
Copy link
Contributor Author

Also slipped in an update to fix broken link for 'View legal' on Request Access page so at least it is not broken.
This link isn't (and never was) entirely appropriate since it is regarding Open Government Licence but even APIs which are not providing open data link to the same terms. #289 elaborates a little more on possible enhancements here.

@ikethecoder ikethecoder merged commit 50433c8 into dev Nov 6, 2024
5 checks passed
@ikethecoder ikethecoder deleted the cypress/gateway-selector branch November 6, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikethecoder ikethecoder ikethecoder approved these changes

@Elson9 Elson9 Elson9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rustyjux @Elson9 @ikethecoder