Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added documentation to create a form using JSON with minimum fields. #20

Merged
merged 5 commits into from
Mar 28, 2024
Merged

Added documentation to create a form using JSON with minimum fields. #20

merged 5 commits into from
Mar 28, 2024

Conversation

bhuvan-aot
Copy link
Contributor

Added documentation to create a form using JSON with minimum fields.

WalterMoar

This comment was marked as outdated.

Sign in to view

@bhuvan-aot
Copy link
Contributor Author

Looks good, just a couple of typo suggestions.

Questions, though:

  • Should we have a standard naming convention for the JSON files?
  • Should we have a standard naming convention for the CHEFS forms?
  • Should we have a standard CHEFS team for the CHEFS form?

Some of these are discussed in #3

  • I have updated the file names to match naming convention.
  • The form name has the Examlple as prefix, should we have the pipe in the middle, not sure what is the convention.
  • Matt owns the form right now, Is this still a open question on who are form owners?

@WalterMoar

This comment was marked as resolved.

Sign in to view
WalterMoar
WalterMoar approved these changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@WalterMoar WalterMoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@bhuvan-aot bhuvan-aot merged commit 3538240 into bcgov:main Mar 28, 2024
@bhuvan-aot bhuvan-aot deleted the docs/create-forrm-min-json-schema branch April 12, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WalterMoar WalterMoar WalterMoar approved these changes

@matthewhall78 matthewhall78 Awaiting requested review from matthewhall78

@vijaivir vijaivir Awaiting requested review from vijaivir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhuvan-aot @WalterMoar