FORMS-1207 - New Map Component for CHEFS #1437
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/common-hosted-form-service into component-skeleton
fixed Unknown Component Render issue
Map submission Data Submission Updated
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
console removed
fixes for marker appearing at geocoder search, replaced with popup
This comment has been minimized.
This comment has been minimized.
Added fix for popup bug
This comment has been minimized.
This comment has been minimized.
Changes to map settings form to enable line input
This comment has been minimized.
This comment has been minimized.
test: FORMS-1527 Cypress test scripts for both export and print temp…
This comment has been minimized.
This comment has been minimized.
Update for Map component include in form Designer
|
Release de7389e deployed at https://chefs-dev.apps.silver.devops.gov.bc.ca/pr-1437 |
usingtechnology
requested changes
Nov 1, 2024
|
|
||
| render() { | ||
| return super.render( | ||
| `<div id="map-${this.componentID}" style="height:400px; z-index:1;"> </div>` |
There was a problem hiding this comment.
can we make the height a property the designer sets?
There was a problem hiding this comment.
Yes, but height customizability never really came up in the ux reviews. I can pass it by minshen
| { | ||
| html: '<h2>Default Values</h2>', | ||
| key: 'simplecontent1', | ||
| type: 'simplecontent', |
There was a problem hiding this comment.
can we use the formio version not our custom simple ones? at some point we may remove the simple ones and then we'd need to know to update this component too.
There was a problem hiding this comment.
updated in latest commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Map component with Point and Circle Marker for getting the latitude and longitude.
Parent ticket : https://bcdevex.atlassian.net/browse/FORMS-1207
This PR introduces a new map component in the Chefs application, integrated into the form designer. This component allows designers to set the center point, default markers, and enables users to view readonly maps within forms. The map component supports both point and circle markers to capture latitude and longitude coordinates.
This change is required to enhance the form designer capabilities, allowing users to interact with and visualize geographical data directly within forms. It solves the problem of needing an intuitive and interactive way to input and display location data.
Fixes #<issue_number> (if applicable)
Types of changes
Checklist
Further comments
This addition aims to provide a robust and user-friendly way to manage and display geospatial data in forms. Alternatives considered included integrating with other map services or using simpler text input fields for coordinates, but those did not meet the usability requirements.