Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keycloak npm library #2314

Merged
merged 7 commits into from
Sep 21, 2024
Merged

Add keycloak npm library #2314

merged 7 commits into from
Sep 21, 2024

Conversation

fergmac
Copy link
Contributor

@fergmac fergmac commented Sep 20, 2024

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [GWELLS-###]
  • Documentation is updated to reflect change [README, functions, team documents]

Description

This PR includes the following proposed change(s):

  • { List all the changes made }
  • { Include any screenshots necessary }

@fergmac fergmac changed the title Debugging keycloack Add keycloak npm library Sep 20, 2024
Copy link
Member

@DerekRoberts DerekRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. :)

keyCloakLogin () {
this.keycloak.init().success(() => {
this.keycloak.login({ idpHint: this.config.sso_idp_hint }).success((authenticated) => {
async keyCloakLogin () {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@PaulGarewal PaulGarewal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fergmac fergmac merged commit 8a4142d into release Sep 21, 2024
11 checks passed
@fergmac fergmac deleted the keycloak-js-fix branch September 21, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants