fix: CE-800 Do not default officer/date on outcome (#472)

bcgov · Jun 18, 2024 · e39d623 · e39d623
1 parent 5210f0b
commit e39d623
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 10 deletions.
diff --git a/...end/src/app/components/containers/complaints/outcomes/oucome-by-animal/create-outcome.tsx b/...end/src/app/components/containers/complaints/outcomes/oucome-by-animal/create-outcome.tsx
@@ -48,7 +48,7 @@ const defaultOutcome: AnimalOutcomeV2 = {
   drugs: [],
   outcome: "",
   officer: "",
-  date: new Date(),
+  date: undefined,
   order: 0,
 };
 
@@ -79,7 +79,7 @@ export const CreateAnimalOutcome: FC<props> = ({ index, assignedOfficer: officer
 
   //-- new input data
   // eslint-disable-line no-console, max-len
-  const [data, applyData] = useState<AnimalOutcomeV2>({ ...defaultOutcome, species, officer });
+  const [data, applyData] = useState<AnimalOutcomeV2>({ ...defaultOutcome, species });
 
   //-- refs
   // eslint-disable-next-line @typescript-eslint/no-array-constructor
@@ -596,7 +596,7 @@ export const CreateAnimalOutcome: FC<props> = ({ index, assignedOfficer: officer
                     onChange={(input: Date) => {
                       handleOutcomeDateChange(input);
                     }}
-                    selectedDate={!data?.date ? new Date() : data.date}
+                    selectedDate={data?.date}
                     classNamePrefix="comp-details-edit-calendar-input"
                     className={"animal-outcome-details-input"}
                     placeholder={"Select"}

diff --git a/frontend/src/app/components/containers/complaints/outcomes/oucome-by-animal/edit-outcome.tsx b/frontend/src/app/components/containers/complaints/outcomes/oucome-by-animal/edit-outcome.tsx
@@ -58,10 +58,7 @@ export const EditOutcome: FC<props> = ({ id, index, outcome, assignedOfficer: of
   const [showModal, setShowModal] = useState(false);
 
   //-- new input data
-  const [data, applyData] = useState<AnimalOutcomeV2>({
-    ...outcome,
-    officer: !outcome.officer ? officer : outcome.officer,
-  });
+  const [data, applyData] = useState<AnimalOutcomeV2>({ ...outcome });
 
   //-- refs
   // eslint-disable-next-line @typescript-eslint/no-array-constructor
@@ -326,7 +323,6 @@ export const EditOutcome: FC<props> = ({ id, index, outcome, assignedOfficer: of
     if (authorizationRef.current && !authorizationRef.current.isValid()) {
       _isValid = false;
     }
-
     return _isValid;
   };
 
@@ -355,8 +351,8 @@ export const EditOutcome: FC<props> = ({ id, index, outcome, assignedOfficer: of
   const handleUpdate = () => {
     if (isValid()) {
       update(data);
+      toggle("");
     }
-    toggle("");
   };
 
   const handleCancel = () => {
@@ -595,7 +591,7 @@ export const EditOutcome: FC<props> = ({ id, index, outcome, assignedOfficer: of
                     onChange={(input: Date) => {
                       handleOutcomeDateChange(input);
                     }}
-                    selectedDate={!data?.date ? new Date() : data.date}
+                    selectedDate={data?.date}
                     classNamePrefix="comp-details-edit-calendar-input"
                     className={"animal-outcome-details-input"}
                     placeholder={"Select"}