Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CE-977 create ceeb decison #607

Merged
merged 37 commits into from
Sep 6, 2024
Merged

Conversation

marqueone-ps
Copy link
Contributor

@marqueone-ps marqueone-ps commented Aug 30, 2024

Description

Create new components for creating and editing ceeb outcome decisions

Story #CE-977

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@marqueone-ps marqueone-ps changed the base branch from main to release/red-irish-lord August 30, 2024 16:57
Mike Sears added 2 commits September 3, 2024 16:35
fixed an issue in the decision-item component that was not displaying the lead agency name correctly as well as retaining the NRIS id or lead agency when those values were edited out
@Scarlett-Truong Scarlett-Truong added the case_management_5 https://dc0a4a-compenf-dev-5-backend.apps.emerald.devops.gov.bc.ca/graphql label Sep 4, 2024
Copy link
Contributor

@Scarlett-Truong Scarlett-Truong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides some notes in redux migration version, it looks good to me. Functionality working as expected.

frontend/src/app/store/migrations/migration-15.ts Outdated Show resolved Hide resolved
frontend/src/app/store/migrations/migration-15.ts Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Sep 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
57.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@afwilcox afwilcox merged commit d011ecb into release/lewis-moon-snail Sep 6, 2024
13 of 15 checks passed
@afwilcox afwilcox deleted the feat/CE-977 branch September 6, 2024 19:52
gregorylavery pushed a commit that referenced this pull request Sep 24, 2024
Co-authored-by: Mike Sears <[email protected]>
Co-authored-by: Barrett Falk <[email protected]>
Co-authored-by: afwilcox <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
case_management_5 https://dc0a4a-compenf-dev-5-backend.apps.emerald.devops.gov.bc.ca/graphql
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants