generated from bcgov/quickstart-openshift
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: CE-977 create ceeb decison #607
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
created ceeb outcome container, and decision components
added thunk file for new code-tables, fixed spelling of rationale, create-decision component data updaintg internal, canceling clears and resets data
reorganized components, added decision-item component
if a complaint is assigned to an officer, the decision input has been updated to pre-select the assigned to officer, input/label clean up
fixed an issue in the decision-item component that was not displaying the lead agency name correctly as well as retaining the NRIS id or lead agency when those values were edited out
Scarlett-Truong
added
the
case_management_5
https://dc0a4a-compenf-dev-5-backend.apps.emerald.devops.gov.bc.ca/graphql
label
Sep 4, 2024
Scarlett-Truong
requested changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides some notes in redux migration version, it looks good to me. Functionality working as expected.
updated decision-form component to update the complaint assignment when the assignTo is modified, added minor update to redux-migration
Scarlett-Truong
approved these changes
Sep 5, 2024
Quality Gate failedFailed conditions |
gregorylavery
pushed a commit
that referenced
this pull request
Sep 24, 2024
Co-authored-by: Mike Sears <[email protected]> Co-authored-by: Barrett Falk <[email protected]> Co-authored-by: afwilcox <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create new components for creating and editing ceeb outcome decisions
Story #CE-977
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in:
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: