fix: CE-1043 investigate issue with pipeline image GitHub images appear to be deleted while in use #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When migrating to production, we shouldn't be rebuilding the release, since this could introduce a change that wasn't tested in the test environment. Instead, we should be grabbing the latest PR that was merged into the release branch, and use that to deploy that image to production.
jon-funk
reviewed
Oct 28, 2024
jon-funk
requested changes
Oct 28, 2024
…-with-pipeline-image-Github-images-appear-to-be-deleted-while-in-use
jon-funk
approved these changes
Oct 28, 2024
…-with-pipeline-image-Github-images-appear-to-be-deleted-while-in-use
|
afwilcox
deleted the
CE-1043-Investigate-issue-with-pipeline-image-Github-images-appear-to-be-deleted-while-in-use
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When migrating to production, we shouldn't be rebuilding the release, since this could introduce a change that wasn't tested in the test environment. Instead, we should be grabbing the latest PR that was merged into the release branch, and use that to deploy that image to production. I believe this will fix the issue with the deleted images in GHCR, as well as fix the issue where the image tags couldn't be found when deploying to production.
Fixes # (issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: