feat: SRS-527 Map Search – Find Me #186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-bcgov
requested changes
Nov 8, 2024
There was a problem hiding this comment.
I think that hooking into redux for a single boolean field is a massive overkill and a regular state field on the level of <MapView /> component should do the trick just fine.
You mentioned that you were getting map context errors before the redux implementation, but looking at the code just now, I'm 99% certain those were unrelated. Happy to hop on a call to debug this together
|
|
||
| import { FindMe } from '../../components/common/icon'; | ||
|
|
||
| export function FindMeControl() { |
There was a problem hiding this comment.
FindMeControl and FindMeButton are almost identical. To avoid code duplication, they should be combined into a single component that accepts settings for its appearance/position as props.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a user, I want to use Find Me so that I can locate my location on the map.
Description:
When a user selects Find Me, a browser notification will appear with text “[.gov.bc.ca] wants to know your location” a user is able to block or allow selection.
When a user follows through with these actions, the map shows where a user is.
Tasks remaining: Unit tests and few changes in css(hover/onClick based on designs being prepared by Harry)
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: