Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create demo app, add new initializer #7

Merged
merged 8 commits into from
Sep 23, 2023
Merged

Conversation

bdbergeron
Copy link
Owner

@bdbergeron bdbergeron commented Sep 23, 2023

Add a new demo app to the Xcode project, showcasing various RemoteImage usages.

Also adds a new RemoteImage initializer that allows for simple usage with just a URL but with a closure to modify the loaded image:

RemoteImage(url: imageURL) {
  $0.resizable().scaledToFit()
}

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Merging #7 (2e5495e) into main (0d68275) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         7    +3     
  Lines          213       239   +26     
=========================================
+ Hits           213       239   +26     
Flag Coverage Δ
iOS 100.00% <100.00%> (ø)
macOS 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
Sources/RemoteImage/RemoteImageViewModel.swift 100.00% <ø> (ø)
Sources/RemoteImage/RemoteImage+Helpers.swift 100.00% <100.00%> (ø)
...ources/RemoteImage/RemoteImage+InitWithCache.swift 100.00% <100.00%> (ø)
Sources/RemoteImage/RemoteImage.swift 100.00% <100.00%> (ø)
...moteImage/RemoteImageViewModel+InitWithCache.swift 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bdbergeron bdbergeron merged commit 3e59a9b into main Sep 23, 2023
4 checks passed
@bdbergeron bdbergeron deleted the bdbergeron/new-initializer branch September 23, 2023 23:30
@bdbergeron bdbergeron added enhancement New feature or request documentation Improvements or additions to documentation labels Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant