Pulse automation condition improved.

- PLS-732 - PLS-733
bdecentgmbh · Apr 11, 2024 · 3e1446e · 3e1446e
1 parent bdb47d3
commit 3e1446e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/conditions/activity/classes/conditionform.php b/conditions/activity/classes/conditionform.php
@@ -112,7 +112,7 @@ public function is_user_completed($instancedata, $userid, \completion_info $comp
             }
             return false;
         }
-        return true;
+        return false;
     }
 
     /**

diff --git a/conditions/cohort/classes/conditionform.php b/conditions/cohort/classes/conditionform.php
@@ -55,7 +55,7 @@ public function load_instance_form(&$mform, $forminstance) {
         $mform->addElement('select', 'condition[cohort][status]', $completionstr, $this->get_options());
         $mform->addHelpButton('condition[cohort][status]', 'condition', 'pulsecondition_cohort');
 
-        $cohorts = cohort_get_all_cohorts('0', '500', '', false);
+        $cohorts = cohort_get_all_cohorts(0, 0);
         $cohorts = $cohorts['cohorts'];
 
         array_walk($cohorts, function(&$value) {
@@ -98,7 +98,7 @@ public function is_user_completed($instancedata, $userid, \completion_info $comp
             }
         }
         // Cohorts are configured but not completed.
-        return !empty($cohorts) ? false : true;
+        return !empty($cohorts) ? true : false;
     }
 
     /**

diff --git a/conditions/session/classes/conditionform.php b/conditions/session/classes/conditionform.php
@@ -113,7 +113,7 @@ public function is_user_completed($instancedata, $userid, \completion_info $comp
             return ($existingsignup) ? true : false;
         }
         // Not configured any session modules.
-        return true;
+        return false;
     }
 
     /**
-Original file line number
+Diff line change
@@ Expand Up @@
                 }
                 return false;
             }
-            return true;
+            return false;
         }
         /**
@@ Expand Down @@