Fix: Improve smart menu font and icon colors, resolves moodle-an-hoch…

…schulen#459
bdecentgmbh · Mar 22, 2024 · 55fac22 · 55fac22
1 parent a5572c0
commit 55fac22
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/scss/boost_union/post.scss b/scss/boost_union/post.scss
@@ -1687,6 +1687,10 @@ body.theme_boost-union-footerbuttonnone.jsenabled {
                         /* Margin removed in the menu description help icon in the menu */
                         i {
                             margin: 0;
+                            /* color white is added in the menu description help icon in the menu */
+                            &:before {
+                                color: var(--info);
+                            }
                         }
                     }
                     /* The font size and opacity reduced when the Menu link is selected as "Heading" option in the
@@ -1837,19 +1841,30 @@ body.theme_boost-union-footerbuttonnone.jsenabled {
                                     margin-bottom: 0;
                                     overflow: hidden;
                                     /* The font style, color, paddign added to the link of the heading
-                                    in the content block for the card dropdown items */
+                                    in the content block for the card dropdown items. Background none is added when the
+                                    background is not given in the settings for the menu items */
                                     a {
                                         font-size: 14px;
                                         color: $white;
                                         font-weight: bold;
                                         padding: 0;
+                                        background: none;
                                         /* Background removed for the link of the heading on hover
                                         in the content block for the card dropdown items */
                                         &:hover,
                                         &:focus,
                                         &:active {
                                             background: none;
                                         }
+                                        /* The icon color is intended to correspond with the text color specified in the menu
+                                        item settings. However, the icon color in the card dropdown menu may be overridden by
+                                        the color defined in the theme style for the navigation, particularly when using the
+                                        "dark" and "bg primary" options in the header. To ensure the desired icon color is
+                                        maintained, the icon color is set to "inherit" with the use of "!important".
+                                        This ensures that the color specified in the text setting will be applied to the icon. */
+                                        i {
+                                            color: inherit !important;
+                                        }
                                     }
                                 }
                                 /* The line height added and "Go" button block aligned right side
@@ -1861,9 +1876,11 @@ body.theme_boost-union-footerbuttonnone.jsenabled {
                                     margin-left: 5px;
                                     a {
                                         /* The color and padding added for the "Go" button in
-                                        the content block of the card dropdown items */
+                                        the content block of the card dropdown items. Background none is added when the
+                                        background is not given in the settings for the menu items */
                                         color: #fff;
                                         padding: 0;
+                                        background: none;
                                         &:hover,
                                         &:focus,
                                         &:active {

diff --git a/templates/smartmenus-cardmenu-children.mustache b/templates/smartmenus-cardmenu-children.mustache
@@ -64,7 +64,7 @@
                                 </h5>
                                 {{^is_action_link}}
                                 <div class="btn-block">
-                                    <a class="dropdown-item " role="menuitem" href="{{{url}}}{{{action}}}" {{#isactive}}aria-current="true"{{/isactive}} tabindex="-1" {{#attributes}}{{name}}="{{value}}"{{/attributes}}>
+                                    <a class="dropdown-item " role="menuitem" href="{{{url}}}{{{action}}}" {{#isactive}}aria-current="true"{{/isactive}} tabindex="-1" {{#attributes}}{{name}}="{{value}}"{{/attributes}} style="{{#itemdata.textcolor}} color:{{{itemdata.textcolor}}};{{/itemdata.textcolor}}">
                                         <i class="fa fa-long-arrow-right"></i>
                                     </a>
                                 </div>