Fix: Add proper JS promise error handling, resolves moodle-an-hochsch…

…ulen#435 (moodle-an-hochschulen#632)
bdecentgmbh · Apr 20, 2024 · 5ffc920 · 5ffc920
1 parent b5a84c5
commit 5ffc920
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 15 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -4,6 +4,10 @@ moodle-theme_boost_union
 Changes
 -------
 
+### Unreleased
+
+* 2024-04-20 - Cleanup: Add proper JS promise error handling, resolves #435.
+
 ### v4.3-r11
 
 * 2024-04-01 - Bugfix: Site support form success message is now shown above advert tiles / the slider on frontpage, partly resolves #488.

diff --git a/amd/build/fontawesome-popover.min.js b/amd/build/fontawesome-popover.min.js
diff --git a/amd/build/fontawesome-popover.min.js.map b/amd/build/fontawesome-popover.min.js.map
diff --git a/amd/build/offcanvas.min.js b/amd/build/offcanvas.min.js
diff --git a/amd/build/offcanvas.min.js.map b/amd/build/offcanvas.min.js.map
diff --git a/amd/src/fontawesome-popover.js b/amd/src/fontawesome-popover.js
@@ -22,7 +22,7 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-define(['jquery', 'theme_boost/popover', 'core/fragment'], function($, popover, Fragment) {
+define(['jquery', 'theme_boost/popover', 'core/fragment', 'core/notification'], function($, popover, Fragment, Notification) {
 
     const SELECTORS = {
         PICKERCONTAINER: '.fontawesome-iconpicker-popover',
@@ -132,7 +132,6 @@ define(['jquery', 'theme_boost/popover', 'core/fragment'], function($, popover,
         }
 
         // Fetch the icons list and setup popover with icons list.
-        // eslint-disable-next-line promise/valid-params
         getIconList().then(function(html) {
 
             $(pickerInput).popover({
@@ -161,7 +160,7 @@ define(['jquery', 'theme_boost/popover', 'core/fragment'], function($, popover,
                 });
             });
             return;
-        }).catch();
+        }).catch(Notification.exception);
 
         document.addEventListener('click', e => {
             if (pickerIsShown && !e.target.closest(SELECTORS.PICKERCONTAINER)) {