Motor position #533
Open
Motor position #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Stefan de Bruijn <[email protected]>
- A reset during a spin up/down delay was causing a crash. - Also added delay register reporting to Huanyang - Note realtime commands are not handled during delays now.
* Fixed WebUI hover problem * Fix bdring#264 - Job killed while opening WebUI
Co-authored-by: Stefan de Bruijn <[email protected]>
|
How about cherry picking fb56fff onto Devt and PR'ing that, so it really is a "small PR". It will take us awhile to swallow the pin extender work. It has to wait until I resolve the problems that keep cropping up with the switchover to the new framework. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR, that stores and is able to retrieve the motor position. I assume PinExtender is taken for the PR here.
It's useful to keep track of the motor position at all times. After homing, the difference in absolute motor position should be pretty much zero - or a step has been lost. This is useful for f.ex. acceleration and max speed tuning.
This PR tracks the motor position and makes it accessible through $MP.