Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New alarms #981

Merged
merged 11 commits into from
Aug 6, 2023
Merged

New alarms #981

merged 11 commits into from
Aug 6, 2023

Conversation

MitchBradley
Copy link
Collaborator

This is a revamp of the alarm handling code, setting the stage for finer-grained alarm states like separate spindle failure and mpos-unknown states.

At present, fine-grained states are not implemented, but the new structure should make it easier to implement them. The new structure unwinds the previously-byzantine code in mc_reset(), separating the jobs of stopping the system and later responding to a user request to reset. Alarm events are now queued the same as other protocol events, eliminating the old global variables rtAlarm and rtReset whose behavior and interactions were confusing.

@MitchBradley
Copy link
Collaborator Author

For G2 and G3 arcs, the soft limit is now tested at the arc level instead of in the individual segments. That makes it possible to reject the entire motion instead of running the part of the arc that was within the limits.

Furthermore, when a soft limit is detected, any previously-planned valid moves are allowed to complete, instead of issuing a feedhold as soon as the parser notices an out-of-limit GCode block.

@bdring
Copy link
Owner

bdring commented Jul 26, 2023

I was testing soft limits alarms. I did a move to cause alarm. When I cleared the alarm my startup_line ran.

This does not happen with v3.7.4

@MitchBradley MitchBradley merged commit fc50c1e into Devt Aug 6, 2023
24 checks passed
@MitchBradley MitchBradley deleted the NewAlarms branch August 6, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants