Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ray-project fork in CI build and Dockerfile #202

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

glennmoy
Copy link
Contributor

Uses our upstream branch of the ray project instead of our forked repo in the CI and docker file

@glennmoy glennmoy changed the title Use ray-project fork in CI build Use ray-project fork in CI build and Dockerfile Oct 16, 2023
@glennmoy glennmoy marked this pull request as draft October 16, 2023 12:46
@glennmoy
Copy link
Contributor Author

A bit of wrinkle in getting this to work is that the ray args can longer be parsed from raylet.out as the full commandisn't reported there anymore. We might be able to still parse some args from raylet.out or elsewhere but it might also be better to revisit #52

@glennmoy
Copy link
Contributor Author

Current issue is that newer versions of RAy ship with the autogenereated protobuf files checked in as of ray-project/ray#39210, and rebuilding ray from source doesn't seem to regenerate them.

Thus it isn't picking up on the Language::JULIA support that we added to the source files.
As a resuilt it cannot spawn worker processes and the task.jl tests fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant