Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate Val #173

Merged
merged 1 commit into from
Jun 29, 2024
Merged

feat: deprecate Val #173

merged 1 commit into from
Jun 29, 2024

Conversation

nstarman
Copy link
Contributor

I noticed in the code that the requirements to begin the deprecation process were fulfilled.

@coveralls
Copy link

coveralls commented Jun 28, 2024

Pull Request Test Coverage Report for Build 9706563998

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.92%

Totals Coverage Status
Change from base Build 9692435229: 0.0%
Covered Lines: 1252
Relevant Lines: 1253

💛 - Coveralls

Signed-off-by: nstarman <[email protected]>
@coveralls
Copy link

coveralls commented Jun 28, 2024

Pull Request Test Coverage Report for Build 9707369488

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.92%

Totals Coverage Status
Change from base Build 9692435229: 0.0%
Covered Lines: 1252
Relevant Lines: 1253

💛 - Coveralls

@wesselb
Copy link
Member

wesselb commented Jun 28, 2024

@nstarman You're totally right! :) This looks great!! Let me know when the PR is ready for review.

@PhilipVinc, I believe you used Val in some places in the past. Do you also think Val can be deprecated, or is there still an edge case where Literal cannot replace Val?

@PhilipVinc
Copy link
Collaborator

We stopped using them long ago in favour of Literal.

@wesselb
Copy link
Member

wesselb commented Jun 28, 2024

@PhilipVinc Thanks! Lets merge this then whenever @nstarman thinks its ready. :)

@nstarman nstarman marked this pull request as ready for review June 28, 2024 20:11
@wesselb wesselb merged commit 456e06b into beartype:master Jun 29, 2024
10 of 11 checks passed
@nstarman nstarman deleted the val branch June 29, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants