Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require typing-extensions>=4.9.0 for python older than 3.11 #182

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

francesco-ballarin
Copy link
Contributor

Fixes #177.

I've got a CI that runs on a docker image with typing_extensions 4.4.0 already installed, and received failures with

/usr/local/lib/python3.10/dist-packages/plum/util.py:5: in <module>
    from typing_extensions import deprecated
E   ImportError: cannot import name 'deprecated' from 'typing_extensions' (/usr/local/lib/python3.10/dist-packages/typing_extensions.py)

Seems like deprecated was introduced in 4.5.0, and improved in 4.9.0, see
https://typing-extensions.readthedocs.io/en/latest/#deprecated
so I chose the latter as lower bound.

Copy link
Collaborator

@PhilipVinc PhilipVinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks!

@coveralls
Copy link

coveralls commented Jul 7, 2024

Pull Request Test Coverage Report for Build 9827132270

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.763%

Totals Coverage Status
Change from base Build 9819027928: 0.0%
Covered Lines: 1265
Relevant Lines: 1268

💛 - Coveralls

@PhilipVinc PhilipVinc merged commit 70212b7 into beartype:master Jul 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants