Cleanup filtration code #235
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
SkeletalDemise
commented
May 17, 2023
SkeletalDemise
commented
- made a macro for decoders, reducing code length and complexity
- cleaned up the imports
- cleaned up code
* made a macro for decoders, reducing code length and complexity * cleaned up the imports * cleaned up code
swanandx
reviewed
May 17, 2023
| pub enum MyResults { | ||
| /// Variant containing successful [`CrackResult`] | ||
| /// Enum representing the result of a cracking operation. | ||
| /// If the checker succeeds, it returns the `Break` variant containing `CrackResult`. |
There was a problem hiding this comment.
those "[]" are for docs to link to CrackResult. [`CrackResult`] will point to docs of CrackResult.
| /// Enum representing the result of a cracking operation. | ||
| /// If the checker succeeds, it returns the `Break` variant containing `CrackResult`. | ||
| /// Otherwise, it returns the `Continue` variant with a vector of `CrackResult` for further processing. | ||
| pub enum CrackResults { |
There was a problem hiding this comment.
it was named that way to avoid confusion between CrackResult and CrackResults
Comment on lines
+85
to
+88
| impl CrackResults { | ||
| #[allow(dead_code)] | ||
| /// Returns the `CrackResult` if the checker succeeds. | ||
| pub fn break_value(self) -> Option<CrackResult> { |
There was a problem hiding this comment.
can we move this impl block under mod test, as break_value is used only in tests.
Comment on lines
+108
to
+125
| create_decoder!(ReverseDecoder), | ||
| create_decoder!(Base64Decoder), | ||
| create_decoder!(Base58BitcoinDecoder), | ||
| create_decoder!(Base58MoneroDecoder), | ||
| create_decoder!(Base58RippleDecoder), | ||
| create_decoder!(Base58FlickrDecoder), | ||
| create_decoder!(Base91Decoder), | ||
| create_decoder!(Base65536Decoder), | ||
| create_decoder!(BinaryDecoder), | ||
| create_decoder!(HexadecimalDecoder), | ||
| create_decoder!(Base32Decoder), | ||
| create_decoder!(MorseCodeDecoder), | ||
| create_decoder!(AtbashDecoder), | ||
| create_decoder!(CaesarDecoder), | ||
| create_decoder!(RailfenceDecoder), | ||
| create_decoder!(CitrixCTX1Decoder), | ||
| create_decoder!(URLDecoder), | ||
| create_decoder!(Base64URLDecoder), |
There was a problem hiding this comment.
would it be better if we can just pass in all of decoders in single macro? like
create_decoders!(ReverseDecoder, Base64Decoder, Base58.....)which would return a array ( doesn't need to a Vec as deocders are fixed right?? ) of Decoders?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.