Added prompt to program_exiting_successful_decoding() in the case tha… #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t the plaintext invisible character percentage is above a threshold of 30%
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Ares team,
Here is my pull request for issue #134. I've added a hash set in
src/storage/mod.rsto hold the different invisible characters, parsed from text files in thesrc/storage/invisible_charsdirectory. The idea is that similar to the "dictionaries" text files, the "invisible chars" text files can act as an editable library for what unicode characters are invisible. For now, I've taken the list from https://invisible-characters.com/.The actual check to see how much of the plaintext is made up of invisible characters is just a simple iterate and count in
program_exiting_successful_decoding(). Below, I've attached a picture of how the prompts look in a few of the different cases:Please let me know if I've missed anything or if there are any improvements/changes I should make.