Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phone Number matches incorrectly #257

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

Phone Number matches incorrectly #257

wants to merge 20 commits into from

Conversation

HamiedAsadi
Copy link

⚠ Pull Requests not made with this template will be automatically closed 🔥

Prerequisites

Why do we need this pull request?

  • Explain the why behind your PR. We can see what it does from the code. But why does it do that?

What GitHub issues does this fix?

  • Fixes #10000

Copy / paste of output

Please copy and paste the output of PyWhat with your new addition using an example that tests this addition below:


    

  
  



      


          

          
  

    
  
    
    

  

  




          

        
      




  





        

       
            



      

  
        

    

  
  

  
          Croquembouche
  
and others
        added 20 commits
        
          October 19, 2022 14:57



  

      

  
  

  
          

  

    

      


  

      
        @Croquembouche
  




      

        
          Create python-app.yml
        

      


      

        

    
    
    

  

    


      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          ac53bda
        
      

    

  







      

  
  

  
          

  

    

      


  

      
        @hyihua
  




      

        
          create a class "Query" to record every query
        

          
                        
      


      

        

    
    
    

  

      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          ed06100
        
      

    

  

    

      
add ".query" into .gitignore to ignore the virtual environment

    







      

  
  

  
          

  

    

      


  

      
        @qchiujunhao
  




      

        
          add class Recorder in helper.py
        

          
                        
      


      

        

    
    
    

  

      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          f37e66c
        
      

    

  

    

      
For actions of recording query history

    







      

  
  

  
          

  

    

      


  

      
        @hyihua
  




      

        
          add function set_date in class Query
        

      


      

        

    
    
    

  

      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          c6877a3
        
      

    

  







      

  
  

  
          

  

    

      


  

      
        @hyihua
  




      

        
          add two functions to compare dates.
        

      


      

        

    
    
    

  

      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          6741ad4
        
      

    

  







      

  
  

  
          

  

    

      


  

      
        @qchiujunhao
  




      

        
          finished the last two methods inside class Recorder
        

      


      

        

    
    
    

  

      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          3461dbb
        
      

    

  







      

  
  

  
          

  

    

      


  

      
        @qchiujunhao
  




      

        
          clean the code for unittest
        

      


      

        

    
    
    

  

      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          9c8fb39
        
      

    

  







      

  
  

  
          

  

    

      


  

      
        @Croquembouche
  




      

        
          Initial Commit for GUI
        

      


      

        

    
    
    

  

      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          24fdce9
        
      

    

  







      

  
  

  
          

  

    

      


  

      
        @hyihua
  




      

        
          correct issues in help.py and finish adding arguments in main function
        

      


      

        

    
    
    

  

      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          99247d9
        
      

    

  







      

  
  

  
          

  

    

      


  

      
        @qchiujunhao
  




      

        
          fixed the bugs: the path of record.csv
        

          
                        
      


      

        

    
    
    

  

      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          ee6f773
        
      

    

  

    

      
And keep the import way: from pywhat.helper import Query, Recoder. Try `pip install .` to install the package, so that for example, you can use `pywhat "****@wayne.edu"` to test the changes.

    







      

  
  

  
          

  

    

      


  

      
        @qchiujunhao
  




      

        
          can only run --query and --print-history
        

      


      

        

    
    
    

  

      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          60e36b8
        
      

    

  







      

  
  

  
          

  

    

      


  

      
        @hyihua
  




      

        
          fix imported mistakes and update ipv6 regex
        

      


      

        

    
    
    

  

      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          01f8c35
        
      

    

  







      

  
  

  
          

  

    

      


  

      
        @hyihua
  




      

        
          update the regex for ipv6 and revert import way
        

      


      

        

    
    
    

  

      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          89903da
        
      

    

  







      

  
  

  
          

  

    

      


  

      
        @qchiujunhao
  




      

        
          printed the intermediate outputs to the users
        

      


      

        

    
    
    

  

      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          bc63590
        
      

    

  







      

  
  

  
          

  

    

      


  

      
        @Croquembouche
  




      

        
          Merge branch 'main' into query_history
        

      


      

        

    
    
    

  

    


      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          a0304e6
        
      

    

  







      

  
  

  
          

  

    

      


  

      
        @Croquembouche
  




      

        
          Merge pull request #27 from Croquembouche/query_history
        

          
                        
      


      

        

    
    
    

  

    


      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          15e74a1
        
      

    

  

    

      
Query history

    







      

  
  

  
          

  

    

      


  

      
        @Croquembouche
  




      

        
          Merge branch 'main' into ipv6_fix
        

      


      

        

    
    
    

  

    


      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          c336958
        
      

    

  







      

  
  

  
          

  

    

      


  

      
        @Croquembouche
  




      

        
          Merge pull request #29 from Croquembouche/ipv6_fix
        

          
                        
      


      

        

    
    
    

  

    


      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          a7e8365
        
      

    

  

    

      
Ipv6 fix

    







      

  
  

  
          

  

    

      


  

      
        @qchiujunhao
  




      

        
          Merge pull request #28 from Croquembouche/print_intermediate_outputs
        

          
                        
      


      

        

    
    
    

  

    


      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          6fca54a
        
      

    

  

    

      
Print intermediate outputs

    







      

  
  

  
          

  

    

      


  

      
        @hyihua
  




      

        
          fixed some issued introduced by merging brannches.
        

      


      

        

    
    
    

  

      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          f789052
        
      

    

  







  












  
  

    

      

  




    


    

      

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          




      

  

    

    
  

    Reviewers
  


    

    No reviews






    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

    None yet







      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  



          


Successfully merging this pull request may close these issues.



  


    
  




        
      

    

  
      

  

    

      4 participants
    

    

        
          @HamiedAsadi 
        
          @Croquembouche 
        
          @hyihua 
        
          @qchiujunhao