Add documentation to run unit-test through Intellij #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratika
requested changes
Jun 7, 2024
| @@ -115,8 +115,8 @@ Output should be something similar to this: | |||
|
|
|||
| .. code:: bash | |||
|
|
|||
| /PATH_TO_JDK/jdk1.8.0_131/bin/java | |||
There was a problem hiding this comment.
Lines 69-71 the right click > create tornadovm [package] does not seem to exist any more. Can we please update also those instructions?
| @@ -115,8 +115,8 @@ Output should be something similar to this: | |||
|
|
|||
| .. code:: bash | |||
|
|
|||
| /PATH_TO_JDK/jdk1.8.0_131/bin/java | |||
| -server -XX:-UseJVMCIClassLoader -XX:-UseCompressedOops -Djava.ext.dirs=/home/michalis/Tornado/tornado/bin/sdk/share/java/tornado -Djava.library.path=/home/michalis/Tornado/tornado/bin/sdk/lib -Dtornado.load.api.implementation=uk.ac.manchester.tornado.runtime.tasks.TornadoTaskGraph -Dtornado.load.runtime.implementation=uk.ac.manchester.tornado.runtime.TornadoCoreRuntime -Dtornado.load.tornado.implementation=uk.ac.manchester.tornado.runtime.common.Tornado -Dtornado.load.device.implementation.opencl=uk.ac.manchester.tornado.drivers.opencl.runtime.OCLDeviceFactory -Dtornado.load.device.implementation.ptx=uk.ac.manchester.tornado.drivers.ptx.runtime.PTXDeviceFactory | |||
There was a problem hiding this comment.
Lines 76-90 please update the cmake version and the jdk-8 profile to match the current version/profiles.
jjfumero
requested changes
Jun 7, 2024
| uk.ac.manchester.tornado.unittests.tools.TornadoTestRunner | ||
| - **Parameters** | ||
| uk.ac.manchester.tornado.unittests.foundation.TestFloats#testVectorFloatAdd | ||
| - **VM Options:** What you copied from ``-server`` and on |
| - **Parameters** | ||
| uk.ac.manchester.tornado.unittests.foundation.TestFloats#testVectorFloatAdd | ||
| - **VM Options:** What you copied from ``-server`` and on | ||
| - **Working Directory:** ``/home/tornadovm`` |
There was a problem hiding this comment.
I think this should be <TORNADO_ROOT>
|
@mikepapadim , is this PR still going? |
Co-authored-by: Juan Fumero <[email protected]>
Co-authored-by: Juan Fumero <[email protected]>
Co-authored-by: Juan Fumero <[email protected]>
let me do another pass, so we can merge it |
Co-authored-by: Juan Fumero <[email protected]>
Co-authored-by: Thanos Stratikopoulos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add entry to documentation to explain the cofiguration for running unit-tests through Intellij.
Backend/s tested
Mark the backends affected by this PR.
OS tested
Mark the OS where this PR is tested.
Did you check on FPGAs?
If it is applicable, check your changes on FPGAs.