Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While building this library on linux, I got errors:
undefined reference to loadFutures
andundefined reference to FUTURE_pango_attr_foreground_alpha_new
.Adding
./vendor/libui/unix/future.c
to cabal file is to resolve this error.Also, lts-10.x (based on ghc-8.2) was released and it will be mainly used in the future, I suggest bumping the lts version.
If you don't want to bump up, just ignore this PR. But at least you need to add
future.c
to get it to work.Sorry for doing two things in one PR, this is such a small change. 😁