Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support exact search with quotes in the notebook #33

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Conversation

GalenReich
Copy link
Collaborator

@GalenReich GalenReich commented Jul 2, 2024

Previously, a search for "Volcano risk" in the notebook would return results matching Volcano and risk separately ❌

Now, a search for "Volcano risk" in the notebook returns results matching Volcano risk exactly ✅

Previously, the notebook used the CLI by invoking !edgar-tool text_search {search arguments}, but this caused problems when doing exact searches because of the behaviour of escape characters (see #24) and Colab string interpolation for the CLI arguments.

This PR reworks the notebook to import and use the SecEdgarScraperCli object in Python directly, which avoids the string interpolation problems when passing quotes for exact searches.

As part of the notebook refactor, there was also a remaining call to sys.exit in the CLI, that caused problems for the colab interface. It was missed in #27 (that closed #17). This PR also cleans up the final sys.exit call and lets the SecEdgarScraperCli object throw the exception directly (to be handled by the implementer).

@GalenReich GalenReich added the bug Something isn't working label Jul 2, 2024
@GalenReich GalenReich merged commit b6cb1a6 into main Jul 2, 2024
@GalenReich GalenReich deleted the Remove-sys.exit branch July 2, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace sys.exit with exceptions and handling
1 participant