Support exact search with quotes in the notebook #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a search for
"Volcano risk"
in the notebook would return results matchingVolcano
andrisk
separately ❌Now, a search for
"Volcano risk"
in the notebook returns results matchingVolcano risk
exactly ✅Previously, the notebook used the CLI by invoking
!edgar-tool text_search {search arguments}
, but this caused problems when doing exact searches because of the behaviour of escape characters (see #24) and Colab string interpolation for the CLI arguments.This PR reworks the notebook to import and use the
SecEdgarScraperCli
object in Python directly, which avoids the string interpolation problems when passing quotes for exact searches.As part of the notebook refactor, there was also a remaining call to sys.exit in the CLI, that caused problems for the colab interface. It was missed in #27 (that closed #17). This PR also cleans up the final
sys.exit
call and lets theSecEdgarScraperCli
object throw the exception directly (to be handled by the implementer).