-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new URL encoding function to align with SEC API #40
Merged
GalenReich
merged 21 commits into
bellingcat:main
from
jordan-gillard:improved-url-generation
Oct 24, 2024
Merged
Create new URL encoding function to align with SEC API #40
GalenReich
merged 21 commits into
bellingcat:main
from
jordan-gillard:improved-url-generation
Oct 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is creates the
generate_search_url_for_kwargs
function to align the EDGAR CLI's generated URLs more closely with the actual EDGAR API. Here are the main differences:&dateRange=custom&startdt=2014-09-07&enddt=2024-09-07
)&dateRange=10y
in URLsHoly See (Vatican City State)
exactly correct on the command line, user's use the international abbrevation, "VAT
")There are also 645 tests for URL generation. All incorporated/principal office ISO codes to SEC location are tested.
Please note that this PR does not replace the existing URL-generation code. This PR is already huge enough and I will do that in a follow-up PR.