Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid setting up a timer if it's unneeded #98

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

deltab
Copy link

@deltab deltab commented Aug 18, 2017

This change checks whether there are any updating-chart elements on a page before setting up the timer that updates them.
Obviously the check is unnecessary on this page, but the demo script gets copied into themes etc. and ends up loaded on pages that don't have any updating charts, wasting CPU time and electricity.

This change checks whether there are any `updating-chart` elements on a page before setting up the timer that updates them.
Obviously the check is unnecessary on *this* page, but the demo script gets copied into themes etc. and ends up loaded on pages that don't have any updating charts, wasting CPU time and electricity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant