-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nits #2016
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe pull request introduces modifications to improve error handling in the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant KVStore
participant SchemaBuilder
User->>KVStore: Call New()
KVStore->>SchemaBuilder: Build schema
SchemaBuilder-->>KVStore: Return success or error
alt Error occurs
KVStore->>KVStore: Panic with error message
else Success
KVStore->>User: Return KVStore instance
end
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@@ -58,7 +58,6 @@ func DefaultCometConfig() *cmtcfg.Config { | |||
cfg.Mempool.Recheck = false | |||
cfg.Mempool.Broadcast = false | |||
cfg.Storage.DiscardABCIResponses = true | |||
cfg.Storage.DiscardABCIResponses = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor duplication
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2016 +/- ##
==========================================
- Coverage 22.38% 22.37% -0.01%
==========================================
Files 358 358
Lines 16045 16050 +5
Branches 12 12
==========================================
Hits 3591 3591
- Misses 12305 12310 +5
Partials 149 149
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we make the fn return an error instead of panic?
A couple of small nits I found while studying the codebase:
KVStore
'sSchemaBuilder.Build()
.SchemaBuilder
s are required to instantiate collections but not really used in their working. Still why not getting all the checks thatBuild
performs? Performances hit should be minimal and happens only at start up.Summary by CodeRabbit