Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Customizable messages #38

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Orlaando-dev
Copy link

This adds customizable messages to LightCleaner.

This is still heavily WIP. However, feedback is appreciated as I work on this :)

@bbayu123
Copy link

From what I know, BKCommonLib and all child plugins use the Localization.yml file to provide customizable messages, so it might be better, perhaps for consistency and unification, to add it to that file instead.
https://dev.bukkit.org/projects/bkcommonlib/pages/general/localization

@Orlaando-dev
Copy link
Author

Orlaando-dev commented Dec 18, 2020

From what I know, BKCommonLib and all child plugins use the Localization.yml file to provide customizable messages, so it might be better, perhaps for consistency and unification, to add it to that file instead.
https://dev.bukkit.org/projects/bkcommonlib/pages/general/localization

ah i see. i might need to scratch what i have so far then. lol.

@bergerkiller
Copy link
Member

I've added a starting stub for localization to the plugin ca89349

Feel free to extend it with your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants