-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api, admin): 3283 - Add manual inscription rights according to dynamic CLE settings #4404
Open
Eric013
wants to merge
5
commits into
main
Choose a base branch
from
feat-manualInscription-3283
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achorein
reviewed
Oct 3, 2024
api/migrations/20241002075633-add-inscription-controls-to-cohort.js
Outdated
Show resolved
Hide resolved
le dropdown "disabled" devrait être gris plutôt que bleu, le DS semblait pourtant le gérer. @achorein Cela dépend du variant. Pour ce dropdown le variant utilisé est "wired":
|
Eric013
force-pushed
the
feat-manualInscription-3283
branch
from
October 7, 2024 10:02
fe93f59
to
2596d0b
Compare
achorein
approved these changes
Oct 7, 2024
Eric013
force-pushed
the
feat-manualInscription-3283
branch
from
October 7, 2024 13:19
2596d0b
to
be09231
Compare
Eric013
force-pushed
the
feat-manualInscription-3283
branch
10 times, most recently
from
October 24, 2024 14:26
b71fcf6
to
a72e0b8
Compare
Eric013
force-pushed
the
feat-manualInscription-3283
branch
from
October 25, 2024 13:12
123d2e1
to
f4fb5d0
Compare
Code Climate has analyzed commit f4fb5d0 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 46.0% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Après la date de fermeture des inscriptions, les référent départementaux, référent régionaux, administrateurs CLE, référents de classe n’ont plus la possibilité d’inscrire manuellement des jeunes.
Il existe des exceptions (ex : DROM) pour lesquels les référents doivent avoir la main passé la date de fin d’inscription pour pouvoir continuer à inscrire des jeunes.
Le but était d'ajouter des paramètres dynamiques pour surcharger les droits d'affichage des boutons d'actions liés aux inscriptions, en fonction des différents types de référents, même si la date des inscriptions est dépassée.
Todo
Ticket / Issue
Notion ticket #3283
Testing instructions