Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing IDs to MyActiveBet #50

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mberk
Copy link
Contributor

@mberk mberk commented Aug 28, 2023

Tests currently failing. Test data needs to be updated

@mberk
Copy link
Contributor Author

mberk commented Aug 28, 2023

I have made the IDs Optional as logically this makes sense if they've been added relatively recently and would not appear on older bets. Tests now pass locally. Failing GitHub Actions tests suggest the problem is nothing to do with these changes per se and rather with pydantic 2.0 and may be related to #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant