Lazily evaluate log message parameters #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petedmarsh
force-pushed
the
lazily-evaluate-log-params
branch
from
e55abe7
to
e007501
Compare
Logging like this:
logger.debug("Hello, %s" % name)
causes the message string to always be interpolated even if the
message is not going to be logged.
Logging like this:
logger.debug("Hello, %s", name)
will mean the string is only ever interpolated if it will be logged.
In practice here this will make little difference if the log level
is INFO or above.
See:
https://docs.python.org/3/howto/logging.html#optimization
https://stackoverflow.com/questions/4148790/lazy-logger-message-string-evaluation
petedmarsh
force-pushed
the
lazily-evaluate-log-params
branch
from
e007501
to
abe2c95
Compare
|
I realized I missed a bunch of cases using |
liampauling
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging like this:
causes the message string to always be interpolated even if the message is not going to be logged.
Logging like this:
will mean the string is only ever interpolated if it will be logged.
In practice here this will make little difference if the log level is INFO
or above.
See:
https://docs.python.org/3/howto/logging.html#optimization https://stackoverflow.com/questions/4148790/lazy-logger-message-string-evaluation