Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove email field before saving user to db #343

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

halfwhole
Copy link
Collaborator

This PR removes the email field (if it exists) from user objects that are to be saved to the database - it acts as a fail-safe in case the object still contains an email

For more context, see #339

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 6d993c3):

https://besomebody--pr343-fix-delete-user-emai-vogg0fko.web.app

(expires Mon, 07 Nov 2022 16:08:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e31b4ef7bdae5637a6e8b743a33548411e2c26b2

@gauravkeerthi
Copy link
Collaborator

I will not merge this PR yet.
I suggest we run the migrations, then check the database manually to see if all email fields have been removed. If that is successful, then we monitor the game for a few days and see what happens as new users sign up and play. If no email fields are added, then I think this PR may not be necessary.

@halfwhole
Copy link
Collaborator Author

I suggest we run the migrations, then check the database manually to see if all email fields have been removed. If that is successful, then we monitor the game for a few days and see what happens as new users sign up and play. If no email fields are added, then I think this PR may not be necessary.

yup makes sense, am good with this too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants